Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNET-1168: Make mongodb connection string used for tests configurable #3654

Closed
wants to merge 1 commit into from

Conversation

kmorkos
Copy link

@kmorkos kmorkos commented Jul 25, 2024

Description

Fixes #3653

Confirmed that this works in the baas CI and all tests pass as expected.

TODO

  • Changelog entry
  • Tests

@kmorkos kmorkos added the no-changelog Used to skip the changelog check label Jul 25, 2024
@cla-bot cla-bot bot added the cla: yes label Jul 25, 2024
Copy link

Pull Request Test Coverage Report for Build 10098296353

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.499%

Totals Coverage Status
Change from base Build 10042303809: 0.0%
Covered Lines: 6908
Relevant Lines: 8322

💛 - Coveralls

Comment on lines -197 to -200
else
{
_baasClient = await BaasClient.Docker(BaasUri!, "local", TestHelpers.Output);
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, this client would always match the one initialized by ExtractBaasSettingsAsync so avoiding threading the connection string here, but lmk if there's some other workflow that relies on this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is invoked when testing against a local baas docker image, so we should probably bring it back, even if most of the time people test against baasaas.

@kmorkos kmorkos requested a review from nirinchev July 25, 2024 17:31
@kmorkos kmorkos marked this pull request as ready for review July 25, 2024 17:31
@kmorkos
Copy link
Author

kmorkos commented Jul 31, 2024

@nirinchev bumping this

@kmorkos kmorkos closed this Sep 16, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring mongodb conn string used for integration tests
2 participants